Moves summary tests to the separate module and fix bug with empty summary generation for the Stats.of #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandelpie
added
ctg-bug
amandelpie
force-pushed
the
amandelpie/feature-198
branch
from
fe9da3f to
2522ab6
Compare
|
@denis-fokin tests are green, please make review, I need this module changes to make summary tests great again |
denis-fokin
approved these changes
Jun 22, 2022
dtim
approved these changes
Jun 22, 2022
utbot-summary-tests/src/test/kotlin/examples/SummaryTestCaseGeneratorTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First of all, provides bug-fix for a minor bug.
To cover this bug with unit-tests this PR proposes some changes in the project architecture: I moved outdated and disabled summary tests to the separate
utbot-summary-testsmodule to avoid circular dependency from theutbot-analyticsmodule that keeps stuff related to the Path Selectors only.Moreover I did some minor refactoring in
utbot-summarymodule.Fixes #198
Type of Change
How Has This Been Tested?
I've added a new test especially for this scenario (preprocessed code from guava-26 with Stats.of method and some related method and classes)
Checklist (remove irrelevant options):